Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: refine openapi table migrate rule source/target #11933

Merged
merged 5 commits into from
Jan 6, 2025
Merged

dm: refine openapi table migrate rule source/target #11933

merged 5 commits into from
Jan 6, 2025

Conversation

River2000i
Copy link
Contributor

@River2000i River2000i commented Dec 25, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4287

What is changed and how it works?

Define TaskTableMigrateRuleSource/TaskTableMigrateRuleTarget as a new type.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/dm Issues or PRs related to DM. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Dec 25, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2024

Hi @River2000i. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 25, 2024
@River2000i River2000i changed the title [WIP]dm: refactor openapi table migrate source/target [WIP]dm: refine openapi table migrate source/target Dec 25, 2024
@River2000i River2000i changed the title [WIP]dm: refine openapi table migrate source/target dm: refine openapi table migrate source/target Jan 3, 2025
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2025
@River2000i River2000i changed the title dm: refine openapi table migrate source/target dm: refine openapi table migrate rule source/target Jan 3, 2025
@lance6716
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jan 3, 2025
@River2000i
Copy link
Contributor Author

/retest

@lance6716 lance6716 requested a review from Copilot January 3, 2025 04:51
Copilot
Copilot AI reviewed Jan 3, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • dm/openapi/spec/dm.yaml: Language not supported
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 6, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 6, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-06 02:24:32.322852383 +0000 UTC m=+147615.611684089: ☑️ agreed by D3Hunter.
  • 2025-01-06 02:25:46.397294858 +0000 UTC m=+147689.686126563: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 686f8ea into pingcap:master Jan 6, 2025
14 checks passed
@River2000i River2000i deleted the openapiFmt branch January 6, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@D3Hunter D3Hunter D3Hunter approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved area/dm Issues or PRs related to DM. contribution This PR is from a community contributor. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refine code
3 participants
@River2000i @lance6716 @D3Hunter